Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ra3xdh activefilter #14

Merged
merged 7 commits into from Jul 24, 2014
Merged

Ra3xdh activefilter #14

merged 7 commits into from Jul 24, 2014

Conversation

ra3xdh
Copy link
Contributor

@ra3xdh ra3xdh commented Jul 16, 2014

Dear Guilherme!

I made some changes according the last comment at PullRequest#13 and I would like to merge it into branch ra3xdh-activefilter. Changes are:

  1. All *.svg and *.png moved to bitmaps directory.
  2. Implemented automatic removing of Cauer filter topology, if Butterworth, Chebyshev or Bessel are selected. Now error message are not showed.
  3. Added QGroupBoxes and Interfaced optimized for laptops with 1366x768 resolution.
  4. I will add later some documentation in TeX format to qucs-doc directory. I think it is should describe underlying mathemathics of filter synthesis algorithms.

Here is screenshot of new interface with QGroupBoxes.

qucsactivefilter2

@ra3xdh ra3xdh mentioned this pull request Jul 16, 2014
Closed
@ra3xdh
Copy link
Contributor Author

ra3xdh commented Jul 23, 2014

I have added Help dialog and Main Menu bar similar to other Qucs-Tools. See last commit.

@guitorri
Copy link
Member

There is an issue with your last commit:
https://travis-ci.org/Qucs/qucs/jobs/30621372#L3639

I guess you have to add helpdialog.cpp to the qucsactivefilter_SOURCES on the Makefile.am.

@guitorri guitorri mentioned this pull request Jul 23, 2014
Closed
@ra3xdh
Copy link
Contributor Author

ra3xdh commented Jul 23, 2014

Issue is fixed. helpdialog.h and helpdialog.cpp are now added to Makefile.am. Travis CI builds OK.

guitorri added a commit that referenced this pull request Jul 24, 2014
@guitorri
Merge pull request #14 from ra3xdh/ra3xdh-activefilter
562a10a 
Ra3xdh activefilter
@guitorri guitorri merged commit 562a10a into Qucs:ra3xdh-activefilter Jul 24, 2014
@guitorri
Copy link
Member

Should we rename the tool to QucsActiveFilter?

./qucsactivefilter.cpp:54:    QAction * helpAbout = new QAction(tr("&About QucsFilter..."), this);
./qucsactivefilter.cpp:533:    "QucsFilter Version " PACKAGE_VERSION+

What about band-pass and band-stop are these supported/implemented ?

@ra3xdh
Copy link
Contributor Author

ra3xdh commented Jul 24, 2014

Yes, it should be renamed. This issue is fixed by myself. See #16 for details.
Band stop and band pass filters are not implemented yet. There are only stubs for them. QucsActiveFilter shows warning when user tries to calculate these filters.
I had no time for this in June, because I had been receiving PhD degree in June. I am busy preparing articles for conferences now. I think to begin these functions implementation in September or October.
While this functions is not implemented, I can remove BandPass and BandStop from the cbxResponse QComboBox in the main window. Should I do it now?

@guitorri
Copy link
Member

guitorri commented Sep 1, 2014

Will you have the time to continue implementing the missing filters?

@ra3xdh
Copy link
Contributor Author

ra3xdh commented Sep 2, 2014

Yes, I will continue BandPass/BandStop filters implementation this month.

@guitorri guitorri mentioned this pull request Sep 12, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ra3xdh @guitorri